You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR primarily focuses on enhancing the functionality and usability of the NetworkSelectors and SelectWithSearch components, as well as improving the handling of backend wallet balances in the application.
Detailed summary
Added closeOnSelect prop to SelectWithSearch for closing popover on selection.
Updated renderOption to close popover when an option is selected.
Modified symbol parameter in utils.ts to be optional and handle empty cases.
Refactored useEngineBackendWalletBalance to accept chainId as a parameter.
Improved rendering of wallet balance with a Skeleton component for loading states.
Updated balance display logic to handle optional symbol more gracefully.
Adjusted SendFundsModal to utilize chainId directly from props instead of deriving it.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR primarily focuses on enhancing the functionality and usability of the
NetworkSelectorsandSelectWithSearchcomponents, as well as improving the handling of backend wallet balances in the application.Detailed summary
closeOnSelectprop toSelectWithSearchfor closing popover on selection.renderOptionto close popover when an option is selected.symbolparameter inutils.tsto be optional and handle empty cases.useEngineBackendWalletBalanceto acceptchainIdas a parameter.Skeletoncomponent for loading states.symbolmore gracefully.SendFundsModalto utilizechainIddirectly from props instead of deriving it.